Make mockgen mock dependencies in vendor dir#99
Conversation
|
This is similar to #28 but has the benefit of not having any conflicts and adds a test. #28 also addresses types in the vendored package. Does this PR do that too? There are also a couple of other differences but I'm not sure what the impact of those are. The reason I haven't, yet, approved either is that I need to take some time to fully understand the way they solve the problem and the possible impact of the changes on existing users. For example, the issue of the code being in read-only directories was raised in #28. I'm not sure if this is hypothetical or a practical concern. |
|
Thanks @balshetzer. yes, this solves the same issue. The difference is it didn't hack the |
|
@balshetzer I almost forgot this PR. Any concerns? |
Fix #4