This repository was archived by the owner on Jun 27, 2023. It is now read-only.
Move argument requirements for Do and DoAndReturn out of example code and into function commentary#572
Merged
codyoss merged 1 commit intogolang:masterfrom Jun 12, 2021
bconway:bconway/comment_do_doandreturn_arg_count
Merged
Move argument requirements for Do and DoAndReturn out of example code and into function commentary#572codyoss merged 1 commit intogolang:masterfrom bconway:bconway/comment_do_doandreturn_arg_count
codyoss merged 1 commit intogolang:masterfrom
bconway:bconway/comment_do_doandreturn_arg_count
Conversation
… and into function commentary Regardless of the result of #558, this is not a new requirement (I believe), and the location of it in the example code was easy to miss. The `Do` version excludes a reference to the output argument count, as the returns are ignored.
codyoss
approved these changes
Jun 12, 2021
Member
codyoss
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regardless of the result of #558, this is not a new requirement (I believe), and the location of it in the example code was easy to miss.
The
Doversion excludes a reference to the output argument count, as the returns are ignored.