This repository was archived by the owner on Jun 27, 2023. It is now read-only.
surface panic when calling Finish is implicit#478
Merged
codyoss merged 3 commits intogolang:masterfrom Sep 11, 2020
codyoss:mock-428
Merged
surface panic when calling Finish is implicit#478codyoss merged 3 commits intogolang:masterfrom codyoss:mock-428
codyoss merged 3 commits intogolang:masterfrom
codyoss:mock-428
Conversation
When Finsh is called from Cleanup, it is not done so in a deffered context. Because of this, we can't recover from panics. The testing package will re-surface any panics but only after the Cleanup functions is executed. Because we were calling t.Fatal we were hiding panics from users of the library when they were using Finish implicitly. Fatal calls runtime.Goexit() under the hood so the panic never gets the chance to be handled by the testing package. Also, removed logging as after thinking about it more it seems a little aggressive to push the feature onto users. Note, when there is a panic and Finish is called from the Cleanup function that a few extra lines will be logged from the calls to ErrorF. This seems like a small price to pay to get the context of the panic
3 tasks
cvgw
reviewed
Sep 11, 2020
cvgw
approved these changes
Sep 11, 2020
This was referenced Mar 11, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Finsh is called from Cleanup, it is not done so in a deffered
context. Because of this, we can't recover from panics. The
testing package will re-surface any panics but only after the
Cleanup functions is executed. Because we were calling t.Fatal we
were hiding panics from users of the library when they were using
Finish implicitly. Fatal calls runtime.Goexit() under the hood so
the panic never gets the chance to be handled by the testing
package.
Also, removed logging as after thinking about it more it seems a
little aggressive to push the feature onto users.
Note, when there is a panic and Finish is called from the Cleanup
function that a few extra lines will be logged from the calls to
ErrorF. This seems like a small price to pay to get the context
of the panic
Fixes: #428