This repository was archived by the owner on Jun 27, 2023. It is now read-only.
fix tests passing when they should not#378
Merged
codyoss merged 1 commit intogolang:masterfrom Jan 12, 2020
codyoss:fail
Merged
fix tests passing when they should not#378codyoss merged 1 commit intogolang:masterfrom codyoss:fail
codyoss merged 1 commit intogolang:masterfrom
codyoss:fail
Conversation
Member
Author
|
This PR now properly shows the generation failures that are happening. It appears with new modules stuff go generate does not behave the same if it is actually in the gopath, hence we were never seeing this failures. There must be some subtlety with generate that I am unaware of. I would like to merge this with the failing CI, then make it top priority to fix these issues. |
Member
Author
|
Pushing this through so it can unblock other issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.