This repository was archived by the owner on Jun 27, 2023. It is now read-only.
refactor method names for reflect/source#376
Merged
codyoss merged 2 commits intogolang:masterfrom Jan 12, 2020
codyoss:rename2
Merged
refactor method names for reflect/source#376codyoss merged 2 commits intogolang:masterfrom codyoss:rename2
codyoss merged 2 commits intogolang:masterfrom
codyoss:rename2
Conversation
The reflect method should be renamed so it does not collide with the reflect package name. As is, it makes import reflect in the code non-idiomatic. Also renamed sourceMode to stay consistent. Noticed this here: #371
cvgw
approved these changes
Jan 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reflect method should be renamed so it does not collide with
the reflect package name. As is, it makes import reflect in the
code non-idiomatic. Also renamed sourceMode to stay consistent.
Noticed this here: #371