This repository was archived by the owner on Jun 27, 2023. It is now read-only.
fix several linting warnings#374
Merged
codyoss merged 2 commits intogolang:masterfrom Dec 27, 2019
codyoss:nitpicking
Merged
Conversation
codyoss
commented
Dec 27, 2019
| g.in() | ||
| for path, pkg := range g.packageMap { | ||
| if path == outputPackagePath { | ||
| for pkgPath, pkg := range g.packageMap { |
Member
Author
There was a problem hiding this comment.
We import path so we should not name variables with the same name as the import.
codyoss
commented
Dec 27, 2019
|
|
||
| func usage() { | ||
| io.WriteString(os.Stderr, usageText) | ||
| _, _ = io.WriteString(os.Stderr, usageText) |
codyoss
commented
Dec 27, 2019
|
|
||
| func (pt PredeclaredType) String(pm map[string]string, pkgOverride string) string { return string(pt) } | ||
| func (pt PredeclaredType) addImports(im map[string]bool) {} | ||
| func (pt PredeclaredType) String(map[string]string, string) string { return string(pt) } |
Member
Author
There was a problem hiding this comment.
If none of the parameters are used, don't name them.
codyoss
commented
Dec 27, 2019
| rep.assertFatal(func() { | ||
| ctrl.Call(s, "VariadicMethod", 1) | ||
| }, "Expected call at", "doesn't match the argument at index 0", | ||
| }, "expected call at", "doesn't match the argument at index 0", |
Member
Author
There was a problem hiding this comment.
errors should not start with a capital letter
cvgw
approved these changes
Dec 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Found a bunch of warnings in my editor so I fixed them.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes
N/A