Update documentation on MinTimes and MaxTimes. Closes #331#334
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1913245 to
5fc2922
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
It's a little unfortunate the CLA requires the commit to include a public email address. It would be nice if it worked with the github no-reply email address. I ended up having to make a separate gmail account to sign the CLA and associate with this commit. |
|
@rkpatel7 Yeah, I am not sure if there is a way around that one. But I appreciate you going thought all of the trouble! |
Updated the documentation to something I think seems to be clearer. Also added two tests for this.