This repository was archived by the owner on Jun 27, 2023. It is now read-only.
narrow types in Recorder method signatures#17
Closed
jmhodges wants to merge 1 commit intogolang:masterfrom
Closed
Conversation
This uses the exact types needed in the Recorder methods. It avoids
spurious expectation misses caused by Go converting untyped
constants to
types that do not match the interface generated for.
One example is float literals passed to a `float32` argument were being
converted on x86_64 machines to `float64` because the Recoder methods
had a `interface{}` arg instead of a `float32` arg.
Fixes golang#16
Contributor
Author
|
I tried working out a test suite for this but it's not quite trivial enough to compile and run test code in process and getting it working with the usual go tools was longer than I could take. It would be cool, though. |
Contributor
|
See my comment on #16. It's currently working as intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the exact types needed in the Recorder methods. It avoids spurious expectation misses caused by Go converting untyped constants to types that do not match the interface generated for.
One example is float literals passed to a
float32argument were being converted on x86_64 machines tofloat64because the Recoder methods had ainterface{}arg instead of afloat32arg.The code needed already existed in GenerateMockMethod, so we break it out with a small generification around return values.
Fixes #16