This repository was archived by the owner on May 9, 2021. It is now read-only.
Flag exported types and methods from the sync package#289
Closed
s111 wants to merge 1 commit intogolang:masterfrom
Closed
Flag exported types and methods from the sync package#289s111 wants to merge 1 commit intogolang:masterfrom
s111 wants to merge 1 commit intogolang:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
I signed it! |
|
CLAs look good, thanks! |
Member
|
Thanks for the PR. This appears to be out of scope and so is being closed. If you feel this is in error please feel free to re-open. Please note this is not the forum to discuss edits to CodeReviewComments. If you wish to propose changes to it please send a mail to golang-nuts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a method which flags exported structs that expose any types or members of the sync package. I believe it is desired to encapsualte your locking mechanisms and not expose them to your users. Is this something that is worth checking for, and does it fit the scope of this tool?