Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.16.13
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.16.14
Choose a head ref
  • 13 commits
  • 34 files changed
  • 10 contributors

Commits on Jan 26, 2022

  1. [release-branch.go1.16] testing: drop unusual characters from TempDir…

    … directory name
    
    Only use safe characters of the test name for the os.MkdirTemp pattern.
    This currently includes the alphanumeric characters and ASCII
    punctuation characters known not to interact with globs.
    
    For #46624
    Fixes #50645
    
    Change-Id: I402c34775b943fed9b97963c52f79245cc16dc1d
    Reviewed-on: https://go-review.googlesource.com/c/go/+/326010
    Trust: Tobias Klauser <tobias.klauser@gmail.com>
    Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
    TryBot-Result: Go Bot <gobot@golang.org>
    Reviewed-by: Bryan C. Mills <bcmills@google.com>
    Reviewed-by: Ian Lance Taylor <iant@golang.org>
    (cherry picked from commit 97cee43)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/378914
    Trust: Ian Lance Taylor <iant@golang.org>
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
    tklauser authored and dmitshur committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    8144f1d View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. [release-branch.go1.16] net/http/internal: use FIPS-compliant certifi…

    …cate
    
    Upgrade the test certificate from RSA 1024 (not FIPS-approved)
    to RSA 2048 (FIPS-approved), allowing tests to pass when
    the dev.boringcrypto branch FIPS-only mode is enabled.
    
    For #48674.
    Fixes #50585.
    
    Change-Id: I613d2f8d0207bf3683fd0df256bf0167604996c5
    Reviewed-on: https://go-review.googlesource.com/c/go/+/353869
    Trust: Damien Neil <dneil@google.com>
    Run-TryBot: Damien Neil <dneil@google.com>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    (cherry picked from commit 90860e0)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/380997
    Trust: Dmitri Shuralyov <dmitshur@golang.org>
    Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    neild authored and dmitshur committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    57d5d8f View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.16] testing/race: fixing intermittent test failure

    Test NoRaceMutexPureHappensBefore in runtime/race/testdata/mutex_test.go
    expects the second spawned goroutine to run after the first.  The test
    attempts to force this scheduling with a 10 millisecond wait.  Following
    a suggestion by Bryan Mills, we force this scheduling using a shared
    variable whose access take place within the existing mutex.
    
    Fixes #50832.
    Updates #35745.
    
    Change-Id: Ib23ec51492ecfeed4752e020401dd25755a669ed
    Reviewed-on: https://go-review.googlesource.com/c/go/+/291292
    Reviewed-by: Bryan C. Mills <bcmills@google.com>
    Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
    Trust: Bryan C. Mills <bcmills@google.com>
    Run-TryBot: Bryan C. Mills <bcmills@google.com>
    TryBot-Result: Go Bot <gobot@golang.org>
    (cherry picked from commit aaed6cb)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/381034
    Trust: Bryan Mills <bcmills@google.com>
    Run-TryBot: Bryan Mills <bcmills@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    dfava authored and dmitshur committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    6cbcf58 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. [release-branch.go1.16] math/big: prevent overflow in (*Rat).SetString

    Credit to rsc@ for the original patch.
    
    Thanks to the OSS-Fuzz project for discovering this
    issue and to Emmanuel Odeke (@odeke_et) for reporting it.
    
    Updates #50699
    Fixes #50700
    Fixes CVE-2022-23772
    
    Change-Id: I590395a3d55689625390cf1e58f5f40623b26ee5
    Reviewed-on: https://go-review.googlesource.com/c/go/+/379537
    Trust: Katie Hockman <katie@golang.org>
    Run-TryBot: Katie Hockman <katie@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Julie Qiu <julie@golang.org>
    (cherry picked from commit ad345c2)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/381337
    katiehockman committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    07ee9e6 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. [release-branch.go1.16] debug/pe,debug/macho: add support for DWARF5 …

    …sections
    
    Adds the same logic used in debug/elf to load DWARF5 sections.
    
    For #49590
    Fixes #50721
    
    Change-Id: Iee05b9927a6f521842b330eab8942ade3fc2bd86
    Reviewed-on: https://go-review.googlesource.com/c/go/+/363895
    Reviewed-by: Ian Lance Taylor <iant@golang.org>
    Trust: Than McIntosh <thanm@google.com>
    (cherry picked from commit 6c36c33)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/379915
    Trust: Ian Lance Taylor <iant@golang.org>
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Alessandro Arzilli <alessandro.arzilli@gmail.com>
    Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
    aarzilli authored and ianlancetaylor committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    355915b View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. [release-branch.go1.16] cmd/go: remove mercurial from bitbucket vcs o…

    …ptions
    
    Mercurial was deprecated as of July 1, 2020 as per https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket
    
    Fixes #50811.
    Updates #50810.
    
    Change-Id: I0d40f84aaa393905cae7c4bed8919b15de9a5f6d
    Reviewed-on: https://go-review.googlesource.com/c/go/+/371720
    Trust: Russ Cox <rsc@golang.org>
    Reviewed-by: Bryan Mills <bcmills@google.com>
    Trust: Bryan Mills <bcmills@google.com>
    (cherry picked from commit 5b1b80b)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/380998
    Run-TryBot: Bryan Mills <bcmills@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Ian Lance Taylor <iant@golang.org>
    Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
    aethanol authored and cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    0a15110 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.16] cmd/compile: don't elide extension for LoadRe…

    …g to FP register on MIPS64
    
    For an extension operation like MOVWreg, if the operand is already
    extended, we optimize the second extension out. Usually a LoadReg
    of a proper type would come already extended, as a MOVW/MOVWU etc.
    instruction does. But for a LoadReg to a floating point register,
    the instruction does not do the extension. So we cannot elide the
    extension.
    
    Updates #50671.
    Fixes #50682.
    
    Change-Id: Id8991df78d5acdecd3fd6138c558428cbd5f6ba3
    Reviewed-on: https://go-review.googlesource.com/c/go/+/379236
    Trust: Cherry Mui <cherryyz@google.com>
    Run-TryBot: Cherry Mui <cherryyz@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: David Chase <drchase@google.com>
    (cherry picked from commit d93ff73)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/379515
    cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    fcd482a View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.16] cmd/compile: remove incorrect arm,arm64 CMP->…

    …CMN transformations
    
    These can go wrong when one of the operands is the minimum integer value.
    
    Fixes #50866.
    
    Change-Id: I238fe284f60c7ee5aeb9dc9a18e8b1578cdb77d0
    Reviewed-on: https://go-review.googlesource.com/c/go/+/381318
    Reviewed-by: Keith Randall <khr@golang.org>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Trust: David Chase <drchase@google.com>
    Run-TryBot: David Chase <drchase@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    (cherry picked from commit b7b44b3)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/381475
    Trust: Michael Knyszek <mknyszek@google.com>
    Run-TryBot: Cherry Mui <cherryyz@google.com>
    dr2chase authored and cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    4d284ea View commit details
    Browse the repository at this point in the history
  4. [release-branch.go1.16] cmd/go/internal/modfetch: do not short-circui…

    …t canonical versions
    
    Since at least CL 121857, the conversion logic in
    (*modfetch).codeRepo.Stat has had a short-circuit to use the version
    requested by the caller if it successfully resolves and is already
    canonical.
    
    However, we should not use that version if it refers to a branch
    instead of a tag, because branches (unlike tags) usually do not refer
    to a single, stable release: a branch named "v1.0.0" may be for the
    development of the v1.0.0 release, or for the development of patches
    based on v1.0.0, but only one commit (perhaps at the end of that
    branch — but possibly not even written yet!) can be that specific
    version.
    
    We already have some logic to prefer tags that are semver-equivalent
    to the version requested by the caller. That more general case
    suffices for exact equality too — so we can eliminate the
    special-case, fixing the bug and (happily!) also somewhat simplifying
    the code.
    
    Updates #35671
    Fixes #50686
    Fixes CVE-2022-23773
    
    Change-Id: I2fd290190b8a99a580deec7e26d15659b58a50b0
    Reviewed-on: https://go-review.googlesource.com/c/go/+/378400
    Trust: Bryan Mills <bcmills@google.com>
    Run-TryBot: Bryan Mills <bcmills@google.com>
    Reviewed-by: Russ Cox <rsc@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    (cherry picked from commit fa4d9b8)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/382839
    Bryan C. Mills authored and cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    de76489 View commit details
    Browse the repository at this point in the history
  5. [release-branch.go1.16] crypto/elliptic: make IsOnCurve return false …

    …for invalid field elements
    
    Updates #50974
    Fixes #50977
    Fixes CVE-2022-23806
    
    Change-Id: I0201c2c88f13dd82910985a495973f1683af9259
    Reviewed-on: https://go-review.googlesource.com/c/go/+/382855
    Trust: Filippo Valsorda <filippo@golang.org>
    Run-TryBot: Filippo Valsorda <filippo@golang.org>
    Reviewed-by: Katie Hockman <katie@golang.org>
    Trust: Katie Hockman <katie@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    FiloSottile authored and cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    6b3e741 View commit details
    Browse the repository at this point in the history
  6. [release-branch.go1.16] cmd/link: force eager binding when using plug…

    …ins on darwin
    
    When building/using plugins on darwin, we need to use flat
    namespace so the same symbol from the main executable and the
    plugin can be resolved to the same address. Apparently, when using
    flat namespace the dynamic linker can hang at forkExec when
    resolving a lazy binding. Work around it by forcing early bindings.
    
    Updates #38824.
    Fixes #50245.
    
    Change-Id: I983aa0a0960b15bf3f7871382e8231ee244655f4
    Reviewed-on: https://go-review.googlesource.com/c/go/+/372798
    Trust: Cherry Mui <cherryyz@google.com>
    Reviewed-by: Than McIntosh <thanm@google.com>
    Reviewed-by: Ian Lance Taylor <iant@golang.org>
    Run-TryBot: Cherry Mui <cherryyz@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    (cherry picked from commit c5fee93)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/373095
    cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    5ef9566 View commit details
    Browse the repository at this point in the history
  7. [release-branch.go1.16] runtime: set vdsoSP to caller's SP consistently

    m.vdsoSP should be set to the SP of the caller of nanotime1,
    instead of the SP of nanotime1 itself, which matches m.vdsoPC.
    Otherwise the unmatched vdsoPC and vdsoSP would make the stack
    trace look like recursive.
    
    We already do it correctly on AMD64, 386, and RISCV64. This CL
    fixes the rest.
    
    Also incorporate CL 352509, skipping a flaky test.
    
    Updates #47324, #50772.
    Fixes #50780.
    
    Change-Id: I98b6fcfbe9fc6bdd28b8fe2a1299b7c505371dd4
    Reviewed-on: https://go-review.googlesource.com/c/go/+/337590
    Trust: Cherry Mui <cherryyz@google.com>
    Trust: Josh Bleecher Snyder <josharian@gmail.com>
    Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
    (cherry picked from commit 217507e)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/380716
    Run-TryBot: Cherry Mui <cherryyz@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    e2277c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. [release-branch.go1.16] go1.16.14

    Change-Id: Ibab854254bba48eab2396bc35a29ec18993f8720
    Reviewed-on: https://go-review.googlesource.com/c/go/+/384495
    Trust: Cherry Mui <cherryyz@google.com>
    Run-TryBot: Cherry Mui <cherryyz@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    cherrymui committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    0a6cf87 View commit details
    Browse the repository at this point in the history
Loading