Skip to content

Change Travis language and remove caching.#27

Merged
arturdryomov merged 2 commits intomasterfrom
ad/travis-language
Jun 15, 2018
Merged

Change Travis language and remove caching.#27
arturdryomov merged 2 commits intomasterfrom
ad/travis-language

Conversation

@arturdryomov
Copy link
Copy Markdown
Member

No description provided.

Comment thread .travis.yml Outdated
@@ -18,7 +20,7 @@ notifications:
email: false

before_cache:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I've just figured that it doesn't work because we run in Docker, we can mount cache into container tho

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, seems useless anyway. We spend too much time on spinning the Docker container, dependencies downloading is the least issue there is. Should I remove cache-related things?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I'm just afraid that mavenCentral/jcenter outage (and they do happen fairly often, especially with jcenter) will bring down CI

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same can be applied to Docker Hub but we use it anyway.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but I have not seen Docker hub down this year while jcenter has outages almost every month

But anyway, let's remove it at least for now since it does nothing :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@artem-zinnatullin
Copy link
Copy Markdown
Contributor

Can you please reflect cache removal in PR title or commit message?

Otherwise lgtm

@arturdryomov arturdryomov changed the title Change Travis default language from default Ruby. Change Travis language and remove caching. Jun 15, 2018
@arturdryomov arturdryomov merged commit e6882db into master Jun 15, 2018
@arturdryomov arturdryomov deleted the ad/travis-language branch June 15, 2018 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants