Tune extensions for streams with variance annotation (out). (#13)#14
Merged
artem-zinnatullin merged 1 commit intogojuno:masterfrom Sep 20, 2017
Merged
Tune extensions for streams with variance annotation (out). (#13)#14artem-zinnatullin merged 1 commit intogojuno:masterfrom
artem-zinnatullin merged 1 commit intogojuno:masterfrom
Conversation
dmitry-novikov
approved these changes
Aug 17, 2017
artem-zinnatullin
suggested changes
Aug 17, 2017
Contributor
artem-zinnatullin
left a comment
There was a problem hiding this comment.
LGTM, but we need to remove cast
| context("Stream with Some") { | ||
| val stream by memoized { | ||
| val stream: Maybe<out Optional<String>> by memoized { | ||
| Maybe.just(Some("a") as Optional<String>) |
Contributor
There was a problem hiding this comment.
So we should remove as Optional<String> then here and in similar places in tests
artem-zinnatullin
approved these changes
Aug 17, 2017
Contributor
artem-zinnatullin
left a comment
There was a problem hiding this comment.
👍 Please ship release after merge
Contributor
|
@dmitry-novikov @ming13 what are we waiting for in this PR? |
dmitry-novikov
approved these changes
Sep 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.