Add support for AndroidX Test Orchestrator#167
Add support for AndroidX Test Orchestrator#167artem-zinnatullin merged 1 commit intogojuno:masterfrom
Conversation
|
In my mind support for the old orchestrator should just be dropped. For those still using it, they can stay on the older version as long as required before they migrate. Which is exactly what they are choosing to do on their support lib code that actually ships to their user base. |
|
Damn androidx rename breaks everything on its way Let's drop support for old orchestrator altogether as @trevjonez commented |
0248482 to
21c76e9
Compare
|
Okay 👍 Note: I've made a breaking change by forcing passing cc #158 |
dailypush
left a comment
There was a problem hiding this comment.
Thank you for updating this to latest android X library.
dailypush
left a comment
There was a problem hiding this comment.
description = "Either true or false to enable/disable running tests via Android Test Orchestrator. False by default.",
May want to consider adding veribage as AndroidX Test Orchestrator for consistency
21c76e9 to
42e40b4
Compare
|
Applied both suggestions let me know if anything else is needed 🙏 |
|
@artem-zinnatullin is there a plan to get a release out w/ this fix or are you waiting at the moment? |
|
@tir38 just cut the release, sorry for delay |
|
I'm too late, but making a breaking change just because it seems more consistent...is bad, now https://github.com/trevjonez/composer-gradle-plugin needs and update too instead of just working nicely. 😢 |
|
I'm curious how this broke the gradle plugin. Is the plugin not pinned to a specific version of Composer? Or does it always grab the latest? |
|
No, it didn't break because it's pinned, but it provides the option to
override composer version.
The difference is, we could use the latest version of composer with the
current plugin without any change, now it requires to do a PR on the plugin
to fix the parameter, update the composer version and do another release.
Not a big issue, just that IMHO breaking the API is something we should do
only when it's really required.
…On Thu, 28 Mar 2019, 16:34 Jason Atwood, ***@***.***> wrote:
I'm curious how this broke the gradle plugin. Is the plugin not pinned to
a specific version of Composer? Or does it always grab the latest?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#167 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGkkBB-1vbmnvIBuBy6rzcBZu7-NvJqhks5vbOEZgaJpZM4a2hP->
.
|
Fixes #166
Another approach would be to keep
--with-orchestratorbut release composer supporting androidx only.