Skip to content
This repository was archived by the owner on Dec 7, 2019. It is now read-only.

Reworked args, fixed issue with instrumentation args separated by commas#104

Merged
yunikkk merged 1 commit intogojuno:masterfrom
yunikkk:refactor-arg-parsing
Oct 23, 2017
Merged

Reworked args, fixed issue with instrumentation args separated by commas#104
yunikkk merged 1 commit intogojuno:masterfrom
yunikkk:refactor-arg-parsing

Conversation

@yunikkk
Copy link
Copy Markdown
Contributor

@yunikkk yunikkk commented Oct 12, 2017

Closes #96.

@artem-zinnatullin
Copy link
Copy Markdown
Collaborator

Fix your email, looks like you've committed with Juno one :)
screen shot 2017-10-14 at 18 00 18

val verboseOutput: Boolean,
val devices: List<String>,
val devicePattern: String
@Parameter(
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw I've started to use https://github.com/xenomachina/kotlin-argparser instead of JCommander, so far so good, you might want to take a look :)

cc @ming13

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will check it

@artem-zinnatullin
Copy link
Copy Markdown
Collaborator

@ming13 let's merge this? See #105

@yunikkk yunikkk force-pushed the refactor-arg-parsing branch from 5fabdd5 to c136f73 Compare October 18, 2017 21:55
@yunikkk yunikkk merged commit bd6c738 into gojuno:master Oct 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants