Skip to content
This repository was archived by the owner on Dec 7, 2019. It is now read-only.

Added flag to keep output.#103

Merged
yunikkk merged 1 commit intogojuno:masterfrom
yunikkk:keep-output-on-exit
Oct 24, 2017
Merged

Added flag to keep output.#103
yunikkk merged 1 commit intogojuno:masterfrom
yunikkk:keep-output-on-exit

Conversation

@yunikkk
Copy link
Copy Markdown
Contributor

@yunikkk yunikkk commented Oct 11, 2017

No description provided.

@trevjonez
Copy link
Copy Markdown

trevjonez commented Oct 12, 2017

are the current output file names meaningful to humans? IIRC it was a random number or some such? It be helpful to make it something deterministic in this same PR as I would like to implement this option in the gradle plugin with the ability to move the output files into the variant directory adjacent to the report outputs. Currently they pop up in the consuming module root dir due to the way gradle works.

@yunikkk yunikkk force-pushed the keep-output-on-exit branch from 8de5c29 to 1cd77a5 Compare October 12, 2017 08:43
@yunikkk
Copy link
Copy Markdown
Contributor Author

yunikkk commented Oct 12, 2017

Currently only instrumentation.output file is named meaningfully, other logs from adb commands have random names (and stored in the root dir). To change that we'll need to modify another library, commander. I'm going to do it, but seems it'll better be the in the next PR.

@yunikkk yunikkk force-pushed the keep-output-on-exit branch from 1cd77a5 to f2c6928 Compare October 13, 2017 13:52
@yunikkk yunikkk requested a review from arturdryomov October 13, 2017 20:50
@artem-zinnatullin
Copy link
Copy Markdown
Collaborator

artem-zinnatullin commented Oct 15, 2017

@trevjonez see gojuno/commander#6 (comment)

It's definitely possible

@yunikkk
Copy link
Copy Markdown
Contributor Author

yunikkk commented Oct 18, 2017

@artem-zinnatullin PTAL)

artem-zinnatullin
artem-zinnatullin approved these changes Oct 18, 2017
View reviewed changes
Copy link
Copy Markdown
Collaborator

@artem-zinnatullin artem-zinnatullin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

composer/src/main/kotlin/com/gojuno/composer/Args.kt Outdated
names = arrayOf("--verbose-output"),
required = false,
arity = 1,
description = "Either `true` or `false` to enable/disable verbose output for Swarmer. `false` by default."
Copy link
Copy Markdown
Collaborator

@artem-zinnatullin artem-zinnatullin Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

Copy link
Copy Markdown
Collaborator

@artem-zinnatullin artem-zinnatullin Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's my copypasta, don't want to look into history :)

@yunikkk yunikkk force-pushed the keep-output-on-exit branch from f2c6928 to d31c1de Compare October 18, 2017 21:54
@yunikkk yunikkk force-pushed the keep-output-on-exit branch from d31c1de to c8b0250 Compare October 23, 2017 22:20
@yunikkk yunikkk merged commit bdff777 into gojuno:master Oct 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arturdryomov arturdryomov Awaiting requested review from arturdryomov

1 more reviewer

@artem-zinnatullin artem-zinnatullin artem-zinnatullin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yunikkk @trevjonez @artem-zinnatullin