Improves code consistency, adds PID management, and enhances user prompts.#29
Merged
Improves code consistency, adds PID management, and enhances user prompts.#29
Conversation
…d documentation Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
… enhance shutdown handling Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
…flexibility Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
…formatting Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to improve code consistency, enhance functionality, and add new features. Key updates include replacing string literals with a custom type for server names, implementing PID file management to prevent duplicate instances, and adding prompts for various functionalities. Additionally, there are updates to dependencies and refactoring for better modularity.
Code Consistency and Refactoring:
BrowserServerName,CommandServerName) with theMoLingServerTypecustom type for better type safety and consistency. ([[1]](https://github.com/gojue/moling/pull/29/files#diff-d28c280801f4a5ac525d036ee232b3823a6bdf7c800c3127cea2a2c1ef8e9d37L35-R36),[[2]](https://github.com/gojue/moling/pull/29/files#diff-255513b4527fd7bbbf2e847c570842c03e574d5974694b8ee056e8bc44a3def3L38-R38))string()conversions where necessary for compatibility with the new type. ([[1]](https://github.com/gojue/moling/pull/29/files#diff-d28c280801f4a5ac525d036ee232b3823a6bdf7c800c3127cea2a2c1ef8e9d37L59-R60),[[2]](https://github.com/gojue/moling/pull/29/files#diff-255513b4527fd7bbbf2e847c570842c03e574d5974694b8ee056e8bc44a3def3L64-R64))New Features:
mlsCommandFuncto prevent duplicate instances of the server. This includes creating and removing the PID file and handling timeouts during shutdown. ([[1]](https://github.com/gojue/moling/pull/29/files#diff-eb154bbd601602eeae895e7af6a12b88cbdb7d585a2d32216c398f68cabcdff5R170-R178),[[2]](https://github.com/gojue/moling/pull/29/files#diff-eb154bbd601602eeae895e7af6a12b88cbdb7d585a2d32216c398f68cabcdff5L222-R283))MLPidNamefor PID file naming and updatedMLROOTPATHtoMLRootPathfor consistency. ([[1]](https://github.com/gojue/moling/pull/29/files#diff-eb154bbd601602eeae895e7af6a12b88cbdb7d585a2d32216c398f68cabcdff5L70-R73),[[2]](https://github.com/gojue/moling/pull/29/files#diff-eb154bbd601602eeae895e7af6a12b88cbdb7d585a2d32216c398f68cabcdff5L80-R83))Dependency Updates:
github.com/mark3labs/mcp-goto versionv0.21.0and updated other indirect dependencies for compatibility. ([go.modL7-R14](https://github.com/gojue/moling/pull/29/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L7-R14))Prompt Additions:
[[1]](https://github.com/gojue/moling/pull/29/files#diff-a34fe2c7669aa7fa6704860ed53b72e0998d9a84a61834f18d7e0b73411e0aeaR1-R69),[[2]](https://github.com/gojue/moling/pull/29/files#diff-4814356be1692906e394cdce7da9138d1f1207710e60e8c24e584fd2764b766bR1-R76),[[3]](https://github.com/gojue/moling/pull/29/files#diff-2a0847855513aab7412e8b56a153cb95993999ee896d00682c3838bdb1e387b3R1-R83))Utility and Modularization:
utilspackage instead ofservicesfor better modularity. ([[1]](https://github.com/gojue/moling/pull/29/files#diff-1da78e247fa9e1955df2583ffcaaa486a6b59c5375b7659cb98c47167da4b9e1L20-R32),[[2]](https://github.com/gojue/moling/pull/29/files#diff-d28c280801f4a5ac525d036ee232b3823a6bdf7c800c3127cea2a2c1ef8e9d37L76-R86))[[1]](https://github.com/gojue/moling/pull/29/files#diff-d28c280801f4a5ac525d036ee232b3823a6bdf7c800c3127cea2a2c1ef8e9d37L76-R86),[[2]](https://github.com/gojue/moling/pull/29/files#diff-d28c280801f4a5ac525d036ee232b3823a6bdf7c800c3127cea2a2c1ef8e9d37L475-R476))