Skip to content

refactor: change log levels from Info to Debug and Warn for improved …#19

Merged
cfc4n merged 2 commits intomasterfrom
client-install-notice
Apr 7, 2025
Merged

refactor: change log levels from Info to Debug and Warn for improved …#19
cfc4n merged 2 commits intomasterfrom
client-install-notice

Conversation

@cfc4n
Copy link
Copy Markdown
Member

@cfc4n cfc4n commented Apr 7, 2025

…logging clarity

…logging clarity

Signed-off-by: cfc4n <cfc4n.cs@gmail.com>
@cfc4n cfc4n requested a review from Copilot April 7, 2025 14:49
@cfc4n cfc4n linked an issue Apr 7, 2025 that may be closed by this pull request
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 7, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

cli/cmd/client.go:58

  • [nitpick] The use of Warn in the exePath log message may be misleading if the situation is normal. Consider using Debug or Info for consistency unless a warning is truly warranted.
logger.Warn().Str("exePath", exePath).Msg("executable path, will use this path to find the config file")

@dosubot dosubot bot added the enhancement New feature or request label Apr 7, 2025
…ging

Signed-off-by: cfc4n <cfc4n.cs@gmail.com>
@cfc4n cfc4n merged commit 33beb53 into master Apr 7, 2025
6 checks passed
@cfc4n cfc4n deleted the client-install-notice branch April 7, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

体验问题

2 participants