fix(ci): preserve release dist during scoop update#962
Merged
Conversation
Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>
87e3e00 to
77359b4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
=========================================
- Coverage 10.99% 8.61% -2.38%
=========================================
Files 173 314 +141
Lines 8671 15743 +7072
=========================================
+ Hits 953 1357 +404
- Misses 7612 14260 +6648
- Partials 106 126 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scoop-updateaction.dist/before the later APT build and artifact/image publishing steps consume it.Root Cause
The
Scoop Updatestep invokedactions/checkout@v4inside the samepublish-releaseworkspace. That checkout ran its clean phase and removed the generated, ignoreddist/directory, causing the followingApt BuildDagger call to fail while resolving--build-dir=./dist.Testing
git diff --checkactionlint .github/workflows/default.yamlCloses #961