fix: Return errors from view command via RunE in artifact cmd#912
Merged
Conversation
Signed-off-by: cotishq <tanishqp101204@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #912 +/- ##
=========================================
- Coverage 10.99% 8.80% -2.19%
=========================================
Files 173 280 +107
Lines 8671 13962 +5291
=========================================
+ Hits 953 1230 +277
- Misses 7612 12615 +5003
- Partials 106 117 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@NucleoFusion @qcserestipy , would like your attention here, like i have to patch those codecov report or its normal to be there and also happy to make changes once you review this |
qcserestipy
approved these changes
May 14, 2026
qcserestipy
left a comment
Collaborator
There was a problem hiding this comment.
@cotishq Thank you for your contribution! LGTM, and you can ignode the codecov failed pipelines for now
artifact cmd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes command error handling in
harbor artifact viewso failures are returned to Cobra and the process exits non-zero instead of silently succeeding.Type of Change
Please select the relevant type.
Changes
artifact view commandfromRuntoRunEinview.go.return fmt.Errorf(...)for parse, prompt, validation, and API failures.1for script/CI reliability.