fix(login): enforce mutual exclusivity of --password and --password-stdin flags#849
Merged
Merged
Conversation
NucleoFusion
approved these changes
May 2, 2026
NucleoFusion
left a comment
Contributor
There was a problem hiding this comment.
lgtm!
Thanks for the contribution
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
=========================================
- Coverage 10.99% 9.01% -1.98%
=========================================
Files 173 272 +99
Lines 8671 13442 +4771
=========================================
+ Hits 953 1212 +259
- Misses 7612 12115 +4503
- Partials 106 115 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tdin flags Signed-off-by: Govind Charpe <govind.charpe16@gmail.com>
cc66a21 to
b0ed752
Compare
qcserestipy
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
harbor logincommand accepted both--passwordand--password-stdinsimultaneously without any error. This caused silent ambiguous behavior where--password-stdinoverwrote the-pvalue with no user-facing warning.Type of Change
Changes
cmd.MarkFlagsMutuallyExclusive("password", "password-stdin")inLoginCommand()— uses Cobra's built-in constraint enforcement-nas a short alias for--context-nameto match convention of all other login flagsTest_Login_Failure_MutuallyExclusiveFlagsto cover the validationTesting
Verified locally: