Skip to content

fix: Adding the --project flag for setting the scope of the label to artifact#822

Merged
bupd merged 2 commits into
goharbor:mainfrom
LAKSHJAIN14:fix/add-scope-flag-for-artifact-label
May 7, 2026
Merged

fix: Adding the --project flag for setting the scope of the label to artifact#822
bupd merged 2 commits into
goharbor:mainfrom
LAKSHJAIN14:fix/add-scope-flag-for-artifact-label

Conversation

@LAKSHJAIN14

@LAKSHJAIN14 LAKSHJAIN14 commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Description

Adds the --project flag to the add and delete command of artifact label since there was no scope defined in the current implementation and was leading to an error, have set the default scope to be global

Type of Change

Please select the relevant type.

  • Bug fix
  • New feature
  • Refactor
  • Documentation update
  • Chore / maintenance

Changes

-After the changes the command is working properly and for reference

image image

LAKSHJAIN14 and others added 2 commits April 21, 2026 13:12
…be added to the artifact

Signed-off-by: LAKSHJAIN14 <jainlaksh07@gmail.com>
Signed-off-by: 3x0ticc <93657396+LAKSHJAIN14@users.noreply.github.com>
@qcserestipy qcserestipy self-requested a review April 28, 2026 06:32
@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.99%. Comparing base (60ad0bd) to head (c8c8788).
⚠️ Report is 146 commits behind head on main.

Files with missing lines Patch % Lines
cmd/harbor/root/artifact/label/add.go 0.00% 14 Missing ⚠️
cmd/harbor/root/artifact/label/delete.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main    #822      +/-   ##
=========================================
- Coverage   10.99%   8.99%   -2.00%     
=========================================
  Files         173     272      +99     
  Lines        8671   13465    +4794     
=========================================
+ Hits          953    1211     +258     
- Misses       7612   12139    +4527     
- Partials      106     115       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qcserestipy qcserestipy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM

@LAKSHJAIN14

Copy link
Copy Markdown
Contributor Author

@bupd friendly ping

@bupd bupd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bupd bupd merged commit c803a5e into goharbor:main May 7, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: Cannot add labels to artifacts

3 participants