fix(ldap): add url and scope validation to ldap ping command#804
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
=========================================
- Coverage 10.99% 8.03% -2.96%
=========================================
Files 173 270 +97
Lines 8671 13173 +4502
=========================================
+ Hits 953 1058 +105
- Misses 7612 12002 +4390
- Partials 106 113 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: PrasunaEnumarthy <eswari.prasuna@gmail.com>
eca8b99 to
f4593f4
Compare
Collaborator
|
Thank you for the contribution, in principle LGTM. Please add screenshots or a screen record of the new behavior in the description. |
Contributor
Author
|
@qcserestipy |
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds input validation for the
harbor ldap pingcommand to prevent invalid inputs from being sent to the API.--ldap-urlusingutils.FormatUrl()andutils.ValidateURL()--ldap-scopeto valid values:0(base),1(one level),2(subtree)This ensures early CLI validation and clearer error messages instead of delayed API failures.
Type of Change
Please select the relevant type.
Changes
--ldap-url--ldap-scope(0–2 only)