Skip to content

chore(lint): enable unused linter#789

Merged
bupd merged 1 commit into
goharbor:mainfrom
PrasunaEnumarthy:chore/enable-unused-linter
Apr 7, 2026
Merged

chore(lint): enable unused linter#789
bupd merged 1 commit into
goharbor:mainfrom
PrasunaEnumarthy:chore/enable-unused-linter

Conversation

@PrasunaEnumarthy

Copy link
Copy Markdown
Contributor

Description

Enables the unused linter in golangci-lint configuration to improve detection of unused code.

Type of Change

Please select the relevant type.

  • Bug fix
  • New feature
  • Refactor
  • Documentation update
  • Chore / maintenance

Changes

  • Enabled the unused linter in .golangci.yaml
  • Kept the change minimal to introduce one linter at a time
  • Allow CI to report any existing unused code for follow-up fixes

Signed-off-by: PrasunaEnumarthy <eswari.prasuna@gmail.com>
@PrasunaEnumarthy PrasunaEnumarthy force-pushed the chore/enable-unused-linter branch from feda210 to d8cdc8a Compare April 1, 2026 13:16
@PrasunaEnumarthy

Copy link
Copy Markdown
Contributor Author

@bupd can you please review this .

@NucleoFusion NucleoFusion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Thanks for the contribution

@bupd bupd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov

codecov Bot commented Apr 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.81%. Comparing base (60ad0bd) to head (d8cdc8a).
⚠️ Report is 129 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #789      +/-   ##
=========================================
- Coverage   10.99%   7.81%   -3.18%     
=========================================
  Files         173     270      +97     
  Lines        8671   13161    +4490     
=========================================
+ Hits          953    1028      +75     
- Misses       7612   12020    +4408     
- Partials      106     113       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bupd bupd merged commit f938cb4 into goharbor:main Apr 7, 2026
7 of 8 checks passed
@bupd

bupd commented Apr 7, 2026

Copy link
Copy Markdown
Member

@PrasunaEnumarthy Congratualtions on your first PR merged. Welcome !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more linters

3 participants