feat: allow localhost as a valid host in URL validation#785
Merged
Conversation
Signed-off-by: marwan562 <mixing.gamer546@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
=========================================
- Coverage 10.99% 7.82% -3.17%
=========================================
Files 173 270 +97
Lines 8671 13163 +4492
=========================================
+ Hits 953 1030 +77
- Misses 7612 12020 +4408
- Partials 106 113 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NucleoFusion
approved these changes
Apr 1, 2026
NucleoFusion
left a comment
Contributor
There was a problem hiding this comment.
lgtm
Thanks for the contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request modifies the
ValidateURLfunction to allowlocalhostas a valid host. Previously, local development addresses lacking a top-level domain (likelocalhostorhttp://localhost:8080) failed the domain validation regex, which prevented users from successfully logging into local Harbor instances.Type of Change
Please select the relevant type.
Changes
"localhost"inpkg/utils/helper.go'sValidateURLfunction before the strict domain regex is evaluated.pkg/utils/helper_test.goto include coverage forlocalhostaddresses using both HTTP and HTTPS schemes, as well as with and without ports.