Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.44%. Comparing base (60ad0bd) to head (5510347).
⚠️ Report is 107 commits behind head on main.

@@            Coverage Diff            @@
##             main    #728      +/-   ##
=========================================
- Coverage   10.99%   7.44%   -3.55%     
=========================================
  Files         173     261      +88     
  Lines        8671   12945    +4274     
=========================================
+ Hits          953     964      +11     
- Misses       7612   11872    +4260     
- Partials      106     109       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bupd The lint is failing because of the new release of the golangci-lint

Fix the lint then.

Looks like there is two gosec issues. Please find the root cause and fix it in a separate PR.

Also we need to find why golangci-lint being latest fails the pipeline - we also need to find the cause for this thing

golangci-lint uses securego/gosec as one of its bundled linters. When gosec releases a new version with new rules, golangci-lint bumps its gosec dependency, which causes new lint failures on previously clean code. Wouldn't it be better to pin the golangci-lint version?

@Sypher845
Pinning golangci-lint restricts updates for other linters and formatters used in the project too. Ideally, it is not a good way to address this problem and we may need to look the cause and fix issues.

i agree we should fix the issues. I was suggesting instead of using the latest (where any PR breaks for a new rule), we pin the version and upgrade it periodically. During each upgrade, we will fix all new lint issues in a single PR. This way no unrelated PR gets blocked by a new lint rule it didn't introduce.

i agree we should fix the issues. I was suggesting instead of using the latest (where any PR breaks for a new rule), we pin the version and upgrade it periodically. During each upgrade, we will fix all new lint issues in a single PR. This way no unrelated PR gets blocked by a new lint rule it didn't introduce.

@Sypher845 - we had like this earlier - and no one is willing to update the golangci-lint to the newest version thats why we now have it as latest - I think if you find any lint issues that is unrelated to the Change Request you are working on.

Please feel free to create a new issue / PR fixing that specific lint issue.

Appreciate the PR #730

@Sypher845 - i believe we should also add this to the builddev too. Please update Thanks.

@bupd
buildDev builds for a single platform and uses the full golang: image, which already includes git. The git commit SHA is being captured correctly in it.
In build, since it targets all platforms, a temp container was needed because we had the Alpine golang container for each platform inside the loop. The temp container is placed before the loop to resolve the git commit SHA once and reuse it for all builds.