replace commands that use Run to use RunE by bhavyaKhatri2703 · Pull Request #679 · goharbor/harbor-cli

bhavyaKhatri2703 · 2026-02-06T09:00:00Z

fixes #675
replaced older commands from Run to RunE with errors being returned properly instead of jusing log.

rshdhere · 2026-02-06T11:53:24Z

@bhavyaKhatri2703 I see your commit messages. it's looking good, but follow contributing.md which has proper format for commit messages

ig dont need for this PR but do consider it in the upcoming PRs

rshdhere · 2026-02-06T11:55:21Z

here's a reference for you, from the official contributing md file. you dont have to force-push it again if you follow this

bhavyaKhatri2703 · 2026-02-06T15:38:03Z

understood thanks for sharing @rshdhere

bhavyaKhatri2703 · 2026-02-11T05:14:37Z

can someone help me with these checks?

codecov · 2026-02-11T05:50:04Z

Codecov Report

❌ Patch coverage is 2.09790% with 140 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.80%. Comparing base (60ad0bd) to head (a6c14ed).
⚠️ Report is 121 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/harbor/root/tag/immutable/list.go	0.00%	15 Missing ⚠️
cmd/harbor/root/project/robot/update.go	0.00%	10 Missing ⚠️
cmd/harbor/root/project/robot/refresh.go	0.00%	8 Missing ⚠️
cmd/harbor/root/project/robot/view.go	0.00%	8 Missing ⚠️
cmd/harbor/root/user/delete.go	0.00%	7 Missing ⚠️
cmd/harbor/root/user/password.go	0.00%	6 Missing and 1 partial ⚠️
cmd/harbor/root/context/switch.go	0.00%	5 Missing and 1 partial ⚠️
cmd/harbor/root/quota/list.go	0.00%	6 Missing ⚠️
cmd/harbor/root/quota/update.go	0.00%	6 Missing ⚠️
cmd/harbor/root/repository/view.go	0.00%	6 Missing ⚠️
... and 16 more

Additional details and impacted files

@@            Coverage Diff            @@
##             main    #679      +/-   ##
=========================================
- Coverage   10.99%   7.80%   -3.19%     
=========================================
  Files         173     270      +97     
  Lines        8671   13166    +4495     
=========================================
+ Hits          953    1028      +75     
- Misses       7612   12025    +4413     
- Partials      106     113       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

NucleoFusion · 2026-02-11T10:15:00Z

So right now, lint is failing. Which probably will be fixed if you run this

dagger call run-doc export --path=./doc

NucleoFusion · 2026-02-11T10:16:07Z

Also, could you remove changes to the artifact directory? It seems to have some different format errors as well.
So It would be better if I address the refactor and the RunE usage in a seperate PR (that I will create). and not have any merge conflicts here

bhavyaKhatri2703 · 2026-02-12T09:42:27Z

Also, could you remove changes to the artifact directory? It seems to have some different format errors as well. So It would be better if I address the refactor and the RunE usage in a seperate PR (that I will create). and not have any merge conflicts here

done

bhavyaKhatri2703 · 2026-02-12T10:00:16Z

So right now, lint is failing. Which probably will be fixed if you run this
dagger call run-doc export --path=./doc

done

NucleoFusion

lgtm!

bupd

@bhavyaKhatri2703 please resolve conflicts

Thanks for the contribution.

bhavyaKhatri2703 · 2026-02-17T17:28:22Z

@bhavyaKhatri2703 please resolve conflicts

Thanks for the contribution.

@bupd resolved, thanks

I think lint is failing maybe because of issues in main

bupd · 2026-03-03T14:58:59Z

@bhavyaKhatri2703 lint issue in main is fixed - please resolve conflicts

Thanks for the contribution

bupd

please rebase onto main

Thanks

Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

bhavyaKhatri2703 · 2026-03-03T16:55:02Z

@bupd pls have a look now , thanks.

bupd

Looks like irrelevant doc changes have been made please fix that

Thanks

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

Signed-off-by: Bhavya Khatri <khatribhavya2703@gmail.com>

bhavyaKhatri2703 · 2026-03-09T13:32:48Z

can someone help me with docs generation?
when i generate docs via dagger call run-doc export --path=./doc
it introduces these whitespace changes d8e4fe0

When i try to revert them back manually lints get failed.

NucleoFusion · 2026-03-09T13:40:00Z

@bhavyaKhatri2703 let the doc changes be, just run run-doc and push it.
run-doc is supposed to change to tell the lint checker that docs have been changed

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

bhavyaKhatri2703 · 2026-03-09T17:36:58Z

@bupd let me know if there are still unwanted changes?

…RunE

Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>

bupd

Please fix the ci - test-code pipeline is failing

otherwise LGTM

@bhavyaKhatri2703 Thanks for the contribution

…RunE

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

bhavyaKhatri2703 · 2026-03-18T10:19:54Z

Please fix the ci - test-code pipeline is failing

otherwise LGTM

@bhavyaKhatri2703 Thanks for the contribution

fixed now.

…RunE

qcserestipy

LGTM

bupd

/lgtm

bhavyaKhatri2703 force-pushed the refactor/replace-Run-commands-with-RunE branch from 24f5850 to f13e913 Compare February 6, 2026 10:13

NucleoFusion approved these changes Feb 17, 2026

View reviewed changes

bupd requested changes Feb 17, 2026

View reviewed changes

bhavyaKhatri2703 requested a review from bupd February 18, 2026 16:41

This was referenced Feb 24, 2026

fix: add missing error returns in command handlers #656

Open

655 issue handling #659

Open

bupd requested changes Mar 3, 2026

View reviewed changes

bupd added the Changes Requesed feedback that must be addressed before merging. label Mar 3, 2026

bhavyaKhatri2703 added 7 commits March 3, 2026 21:20

replace commands that use Run to use RunE

a5b961e

Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>

refactor: fix logs.go

fa50c27

Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>

refactor: fix logs.go

0624f10

Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>

fix(robot): fix update.go

c1632ec

Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>

fix(artifact): revert changes

67fd3d6

Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>

doc: generate documentation

d8e4fe0

Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>

fix(quota):fix indentation

71bf620

Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>

bhavyaKhatri2703 force-pushed the refactor/replace-Run-commands-with-RunE branch from 76761fc to 71bf620 Compare March 3, 2026 15:59

bhavyaKhatri2703 added 3 commits March 3, 2026 21:44

fix:issues

4e1cd57

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

fix(user):password

7d91188

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

fix(user):password.go

607f625

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

bhavyaKhatri2703 added 2 commits March 3, 2026 22:06

fix(user):add logrus

9f9601f

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

fix:lint format issues

cd882f2

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

bhavyaKhatri2703 requested a review from bupd March 3, 2026 16:54

bupd reviewed Mar 3, 2026

View reviewed changes

bhavyaKhatri2703 added 6 commits March 5, 2026 14:30

fix(docs):revert changes

3228bb6

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

fix(docs):revert changes

2c4c718

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

fix(docs):revert changes

d197bd0

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

fix(docs): revert changes

5b0668e

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

fix(docs)

862a737

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

Merge branch 'main' into refactor/replace-Run-commands-with-RunE

ec02225

Signed-off-by: Bhavya Khatri <khatribhavya2703@gmail.com>

bhavyaKhatri2703 added 3 commits March 9, 2026 22:46

fix(docs)

fa35bc5

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

doc:Generate documentation

2c0ba87

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

fix(robot):Return errors instead of logging

fc26845

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

bhavyaKhatri2703 requested a review from bupd March 9, 2026 17:37

bhavyaKhatri2703 and others added 2 commits March 15, 2026 19:26

Merge branch 'goharbor:main' into refactor/replace-Run-commands-with-…

60e2006

…RunE

Delete golangci-lint.report

5e7bf97

Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>

bupd requested changes Mar 17, 2026

View reviewed changes

bhavyaKhatri2703 added 2 commits March 18, 2026 12:15

Merge branch 'goharbor:main' into refactor/replace-Run-commands-with-…

76f3e5c

…RunE

fix(user): use RunE instead of Run in tests

74d3b7e

Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>

Merge branch 'goharbor:main' into refactor/replace-Run-commands-with-…

a6c14ed

…RunE

qcserestipy self-requested a review March 25, 2026 15:55

qcserestipy approved these changes Mar 25, 2026

View reviewed changes

bupd approved these changes Mar 31, 2026

View reviewed changes

bupd merged commit ad44911 into goharbor:main Mar 31, 2026
6 of 8 checks passed

Conversation

bhavyaKhatri2703 commented Feb 6, 2026

Uh oh!

rshdhere commented Feb 6, 2026

Uh oh!

rshdhere commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bhavyaKhatri2703 commented Feb 6, 2026

Uh oh!

bhavyaKhatri2703 commented Feb 11, 2026

Uh oh!

codecov Bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

NucleoFusion commented Feb 11, 2026

Uh oh!

NucleoFusion commented Feb 11, 2026

Uh oh!

bhavyaKhatri2703 commented Feb 12, 2026

Uh oh!

bhavyaKhatri2703 commented Feb 12, 2026

Uh oh!

NucleoFusion left a comment

Choose a reason for hiding this comment

Uh oh!

bupd left a comment

Choose a reason for hiding this comment

Uh oh!

bhavyaKhatri2703 commented Feb 17, 2026

Uh oh!

bupd commented Mar 3, 2026

Uh oh!

bupd left a comment

Choose a reason for hiding this comment

Uh oh!

bhavyaKhatri2703 commented Mar 3, 2026

Uh oh!

bupd left a comment

Choose a reason for hiding this comment

Uh oh!

bhavyaKhatri2703 commented Mar 9, 2026

Uh oh!

NucleoFusion commented Mar 9, 2026

Uh oh!

bhavyaKhatri2703 commented Mar 9, 2026

Uh oh!

bupd left a comment

Choose a reason for hiding this comment

Uh oh!

bhavyaKhatri2703 commented Mar 18, 2026

Uh oh!

qcserestipy left a comment

Choose a reason for hiding this comment

Uh oh!

bupd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rshdhere commented Feb 6, 2026 •

edited

Loading

codecov Bot commented Feb 11, 2026 •

edited

Loading