fix: require valid project ID for project labels creation#641
Merged
bupd merged 3 commits intoMar 3, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
=========================================
- Coverage 10.99% 7.45% -3.54%
=========================================
Files 173 261 +88
Lines 8671 12930 +4259
=========================================
+ Hits 953 964 +11
- Misses 7612 11857 +4245
- Partials 106 109 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bupd
requested changes
Jan 27, 2026
bupd
left a comment
Member
There was a problem hiding this comment.
/lgtm @Sypher845 please add a test for the changes made. Thanks
Contributor
Author
|
So sorry, I missed the notification for this! Working on it!! |
Signed-off-by: Sypher845 <suyashpatil845@gmail.com>
Signed-off-by: Sypher845 <suyashpatil845@gmail.com>
432a4c3 to
7d08f42
Compare
Contributor
Author
|
@bupd i have added the tests, please take a look. |
qcserestipy
approved these changes
Feb 21, 2026
qcserestipy
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #640
This pull request improves the label creation command in the Harbor CLI by enhancing error handling and adding validation for project-specific labels. The main changes focus on making the command more robust and user-friendly.
Validation for project-specific labels:
'p'), a validProjectIDmust be provided. If not, a clear error message is returned.Result
Result
