Codecov Report

❌ Patch coverage is 0% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.23%. Comparing base (60ad0bd) to head (14f8003).
⚠️ Report is 103 commits behind head on main.

@@            Coverage Diff            @@
##             main    #634      +/-   ##
=========================================
- Coverage   10.99%   7.23%   -3.76%     
=========================================
  Files         173     261      +88     
  Lines        8671   12923    +4252     
=========================================
- Hits          953     935      -18     
- Misses       7612   11880    +4268     
- Partials      106     108       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vg006 fix lint and let me know

@bupd
I just fixed the issue, tested and built locally.

@vg006 curious what screenrecorder are you using here. to get the gifs.

Btw I use Charm's vhs for recording the terminal sessions, mostly for CLI tool.
I define custom tape files to produce desired gifs, but you need to configure them at the end.

Just record, test and repeat, until you get it correctly 😄

@qcserestipy As you can see here, the logger is set with io.Discard as a output writer in non-verbose mode, neither used os.StdOut nor os.StdErr writers.

So this silences the logrus. I agree that it is logged in the verbose mode, but normally a command should provide a proper closure upon the exit right. So I set it explicitly using the Cobra's writers within the command itself, instead of tweaking the global configuration.

@bupd How about this change?

1. Removed the log.SetOutput
2. Update the logic to render a fancy message in case of no users.

I updated the output, but using existing styles in the project's views package.

Additionally just added a utility function RedText which returns the given string wrapped by ANSI sequences for Red color, using is too using the existing constants.

@vg006 @bupd I think changing the styling and color for this command only is not really necessary. Since we return simple text in every other command it could be confusing that it is different here. Just returning the error message as text should be the simplest. I guess fmt.Errorf and fmt.Printf should be enough.

I thought of improving the UX and I have just used the styles that are already defined in the project. Just added a utility function that returns the given text, wrapped by ANSI sequences.

Fine, then as per your suggestion, let me make this PR minimal.
But I will propose this type of styled messages in my ongoing work #635, which will have a good impression on the UI and improves usability.

@qcserestipy I just updated the view, so that a line stating that "No users found in the registry" is printed simply, without any fancy view and ANSI sequences.

I have also update the command to return error (from Run to RunE). So now it will throw error in case of invalid operation or any failure and exit with a status code 1.

Preview

@bupd @qcserestipy
The PR is updated as per the reviews and suggestions above and it is ready to merge.