fix: reject negative page-size values in list commands#631
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
=========================================
- Coverage 10.99% 7.13% -3.86%
=========================================
Files 173 260 +87
Lines 8671 12923 +4252
=========================================
- Hits 953 922 -31
- Misses 7612 11893 +4281
- Partials 106 108 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
qcserestipy
requested changes
Feb 6, 2026
Collaborator
There was a problem hiding this comment.
Thank you for your contribution. The over all implementation already looks good. To make this PR complete please also take care of missing list commands such as:
instance listproject member listrobot listproject robot listlogs(not a list command, but it also has thepage-sizeflag.)
81d9ad4 to
908492f
Compare
Contributor
Author
|
@qcserestipy added the check to the remaining commands. Please take a look. |
qcserestipy
approved these changes
Feb 7, 2026
qcserestipy
left a comment
Collaborator
There was a problem hiding this comment.
@Sypher845 Looks nice, thank you!
bupd
requested changes
Feb 10, 2026
bupd
left a comment
Member
There was a problem hiding this comment.
@Sypher845 heads up merge conflicts - please fix Thanks
Signed-off-by: Sypher845 <suyashpatil845@gmail.com>
908492f to
79fcf39
Compare
Contributor
Author
|
@bupd PTAL :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #627
Previously, negative page-size values (e.g.,
--page-size -1) were accepted without validation. This fix adds validation to reject negative values.Affected commands:
project listuser listrepository listschedule listregistry listquota listreplication policies listreplication executions listartifact listlabels listinstance listproject member listrobot listproject robot listlogs(not a list command, but it also has the page-size flag.)