fix: make comment field optional in user create command#629
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
=========================================
- Coverage 10.99% 7.16% -3.84%
=========================================
Files 173 260 +87
Lines 8671 12876 +4205
=========================================
- Hits 953 922 -31
- Misses 7612 11846 +4234
- Partials 106 108 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NucleoFusion
suggested changes
Feb 6, 2026
NucleoFusion
left a comment
Contributor
There was a problem hiding this comment.
Could also probably add an (optional) to the description string. (for -h help)
Everything else works as intended.
4c9d94f to
7eba311
Compare
Contributor
Author
|
@NucleoFusion done. Please take a look |
7eba311 to
db6f753
Compare
Signed-off-by: Sypher845 <suyashpatil845@gmail.com>
db6f753 to
a27fd9f
Compare
Contributor
Author
|
@bupd solved the conflicts, PTAL :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #628
The
user createcommand previously required ALL fields including the optionalcommentfield for non-interactive mode. Now users can create accounts with only the required fields