Skip to content

Feature: Extending Retention Cmd PR#564

Merged
bupd merged 22 commits into
goharbor:mainfrom
NucleoFusion:feat/retention
May 12, 2026
Merged

Feature: Extending Retention Cmd PR#564
bupd merged 22 commits into
goharbor:mainfrom
NucleoFusion:feat/retention

Conversation

@NucleoFusion

@NucleoFusion NucleoFusion commented Oct 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adding Retention support

  • Adding retention list command.
  • Adding retention create command.
  • Adding retention delete command.
2025-11-01.19-06-57.mp4

resolves #183
buids upon #364

@codecov

codecov Bot commented Oct 28, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 478 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.51%. Comparing base (60ad0bd) to head (7ced3d7).
⚠️ Report is 159 commits behind head on main.

Files with missing lines Patch % Lines
pkg/api/retention_handler.go 0.00% 135 Missing ⚠️
cmd/harbor/root/tag/retention/create.go 0.00% 70 Missing ⚠️
pkg/views/retention/list/view.go 0.00% 59 Missing ⚠️
cmd/harbor/root/tag/retention/list.go 0.00% 52 Missing ⚠️
pkg/views/retention/create/view.go 0.00% 51 Missing ⚠️
cmd/harbor/root/tag/retention/delete.go 0.00% 48 Missing ⚠️
pkg/views/retention/select/view.go 0.00% 36 Missing ⚠️
cmd/harbor/root/tag/retention/cmd.go 0.00% 18 Missing ⚠️
pkg/prompt/prompt.go 0.00% 7 Missing ⚠️
cmd/harbor/root/tag/cmd.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             main    #564      +/-   ##
=========================================
- Coverage   10.99%   8.51%   -2.48%     
=========================================
  Files         173     288     +115     
  Lines        8671   14443    +5772     
=========================================
+ Hits          953    1230     +277     
- Misses       7612   13096    +5484     
- Partials      106     117      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NucleoFusion NucleoFusion marked this pull request as ready for review November 1, 2025 13:49
@NucleoFusion NucleoFusion changed the title [WIP] Feature: Extending Retention Cmd PR Feature: Extending Retention Cmd PR Nov 4, 2025
This was referenced Nov 12, 2025
Closed
Closed
@bupd bupd self-requested a review November 25, 2025 13:42
bupd
bupd requested changes May 6, 2026
View reviewed changes

@bupd bupd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed and few changes are needed. before this pr is ready for merge

Comment thread cmd/harbor/root/tag/retention/delete.go Outdated
Comment thread cmd/harbor/root/tag/retention/delete.go Outdated
Comment thread pkg/api/retention_handler.go Outdated
Comment thread pkg/api/retention_handler.go Outdated
Comment thread pkg/api/retention_handler.go Outdated
Comment thread pkg/views/retention/create/view.go Outdated
@bupd

bupd commented May 6, 2026

Copy link
Copy Markdown
Member

@NucleoFusion looks like lint is failing - please also fix that - https://github.com/goharbor/harbor-cli/actions/runs/25415495532/job/74546023723#step:5:26

@bupd bupd requested review from bupd and Copilot and removed request for bupd May 6, 2026 04:03
@bupd bupd added the next-release Potential PRs that needs to be merged before cutting the next release. label May 6, 2026
Copilot AI reviewed May 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@bupd

bupd commented May 8, 2026

Copy link
Copy Markdown
Member

@codex review

Althaf66 and others added 13 commits May 11, 2026 16:39
@Althaf66 @bupd
add harbor retention create cmd
bbc152e 
Signed-off-by: ALTHAF <althafasharaf02@gmail.com>
@Althaf66 @bupd
list and delete cmd for retention
a5ec1f6 
Signed-off-by: ALTHAF <althafasharaf02@gmail.com>
@rizul2108 @bupd
change file structure
3679be6 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@rizul2108 @bupd
fix lint issues
d61530d 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@rizul2108 @bupd
correct logic for listing and deleting retention
83b7737 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@rizul2108 @bupd
modify table view
81b545e 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@rizul2108 @bupd
improve error handling
90d677b 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@rizul2108 @bupd
enhance desc and error handling
c7c7091 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@rizul2108 @bupd
add documentation
c61bfeb 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@rizul2108 @bupd
fix lint issues
257e211 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@rizul2108 @bupd
minor change
7ea6272 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@rizul2108 @bupd
fix lint issues
0719197 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

fix lint issues

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

lint errors fix

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

minor fixes

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

uncomment login test

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@rizul2108 @bupd
update create and delete funcs
1e7682b 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
rizul2108 and others added 9 commits May 11, 2026 16:39
@rizul2108 @bupd
makes delete more desc and fix lint issues
ab2990f 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@rizul2108 @bupd
update docs and desc
a485a7d 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@rizul2108 @bupd
modify list output
ff9a12c 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@rizul2108 @bupd
fmt fix
2d372f2 
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
@NucleoFusion @bupd
rebase: rebasing PR and resolving errors
6159770 
Signed-off-by: NucleoFusion <lakshit.singh.mail@gmail.com>
@NucleoFusion @bupd
fix: doc and lint
75c1d8c 
Signed-off-by: NucleoFusion <lakshit.singh.mail@gmail.com>
@NucleoFusion @bupd
fix: doc and lint
0221a62 
Signed-off-by: NucleoFusion <lakshit.singh.mail@gmail.com>
@NucleoFusion @bupd
fix: rebase and fixes
22aff89 
Signed-off-by: NucleoFusion <lakshit.singh.mail@gmail.com>
@NucleoFusion @bupd
fixes
7ced3d7 
Signed-off-by: NucleoFusion <lakshit.singh.mail@gmail.com>
@bupd bupd force-pushed the feat/retention branch from f2e1041 to 7ced3d7 Compare May 11, 2026 11:09
bupd
bupd approved these changes May 12, 2026
View reviewed changes

@bupd bupd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bupd bupd merged commit 19e9a10 into goharbor:main May 12, 2026
6 of 8 checks passed
@NishchayRajput NishchayRajput mentioned this pull request May 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@bupd bupd bupd approved these changes

Assignees

No one assigned

Labels

next-release Potential PRs that needs to be merged before cutting the next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement retention command

5 participants

@NucleoFusion @bupd @Althaf66 @rizul2108