feature: rebasing and working on LDAP commands#550
Merged
Conversation
Signed-off-by: bupd <bupdprasanth@gmail.com>
This command allows to ping the ldap server from the cli Signed-off-by: bupd <bupdprasanth@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
=========================================
- Coverage 10.99% 6.70% -4.29%
=========================================
Files 173 258 +85
Lines 8671 15379 +6708
=========================================
+ Hits 953 1031 +78
- Misses 7612 14241 +6629
- Partials 106 107 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: NucleoFusion <lakshit.singh.mail@gmail.com>
Signed-off-by: NucleoFusion <lakshit.singh.mail@gmail.com>
Signed-off-by: NucleoFusion <lakshit.singh.mail@gmail.com>
Signed-off-by: NucleoFusion <lakshit.singh.mail@gmail.com>
Signed-off-by: NucleoFusion <lakshit.singh.mail@gmail.com>
Vad1mo
approved these changes
Sep 30, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces LDAP commands to the Harbor CLI, enabling administrators to manage and import LDAP users directly through the command line interface. The implementation builds on the existing configuration framework to provide seamless integration with Harbor's LDAP settings.
- Adds new LDAP API handlers for user search, server ping, user import, and group search operations
- Implements three CLI commands:
ldap ping,ldap search, andldap importfor LDAP server management - Updates documentation with comprehensive man pages and CLI documentation for all new LDAP commands
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/api/ldap_handler.go | New API handlers for LDAP operations including user search, server ping, user import, and group search |
| cmd/harbor/root/ldap/*.go | CLI command implementations for ldap ping, search, and import subcommands |
| cmd/harbor/root/cmd.go | Integration of LDAP commands into the main CLI structure |
| doc/ | Documentation updates including man pages and CLI docs for all new LDAP commands |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Nucleo Fusion <148791547+NucleoFusion@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Nucleo Fusion <148791547+NucleoFusion@users.noreply.github.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces LDAP commands to the CLI, enhancing Harbor's capabilities by allowing the management and import of LDAP users directly through the command line interface.
The addition of LDAP commands follows the recent integration of configuration commands #114 into the CLI. The configuration commands provide a foundational framework that allows administrators to set and manage Harbor configurations from the command line. By building on this foundation, the LDAP commands leverage the existing configuration setup, ensuring that user management aligns seamlessly with the configured LDAP settings.
Added Commands:
Conclusion:
This enhancement significantly improves the operational efficiency and capabilities of Harbor's CLI. It makes LDAP user management more accessible, quicker, and more integrated.