Improve table grid controls and form validation (Follow‑up Improvements to PR #489)#503
Merged
Merged
Conversation
- refactor(tablegrid): change toggle controls to explicit on/off actions - feat(tablegrid): add table-wide toggle shortcuts (ctrl+a, ctrl+d) - fix(robot): improve validation for robot creation expiration time - fix(cmd): convert Run to RunE for proper error handling in robot list - docs(ui): update keyboard shortcut documentation in footer text Signed-off-by: Patrick Eschenbach <patrickeschenbach96@gmail.com>
Signed-off-by: Patrick Eschenbach <patrickeschenbach96@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
=========================================
- Coverage 10.99% 9.11% -1.88%
=========================================
Files 173 190 +17
Lines 8671 10510 +1839
=========================================
+ Hits 953 958 +5
- Misses 7612 9446 +1834
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Patrick Eschenbach <patrickeschenbach96@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the requested changes from the review of PR #489 and adds several usability enhancements.
Implemented Changes
Table Grid Controls
Improved control clarity – toggles replaced with explicit on/off actions
Ctrl + J— Turn ON all cells in the current rowCtrl + K— Turn OFF all cells in the current rowCtrl + H— Turn ON all cells in the current columnCtrl + L— Turn OFF all cells in the current columnTable‑wide controls
Ctrl + A— Turn ON every cell in the tableCtrl + D— Turn OFF every cell in the tableUpdated documentation – footer text now clearly shows the purpose of each shortcut
Robot Creation Form
Better validation
0or negative values (except‑1)Default value – sets duration to
‑1(no expiration) when the user enters0Command Handling
RuntoRunEfor proper error handling in the robot list commandRelated Issues
Addresses feedback from PR #489.