security: require authentication for attachment uploads#8128
Merged
Conversation
Move `/issues/attachments` and `/releases/attachments` endpoints from the `ignSignIn` route group to a new group protected by `reqSignIn`. Previously, these endpoints were accessible without authentication when `RequireSignInView` was disabled (the default), allowing anonymous users to upload arbitrary files to the server. Reported-by: brelinsky-openai Reference: GHSA-fc3h-92p8-h36f Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/issues/attachmentsand/releases/attachmentsendpoints fromignSignIntoreqSignInroute groupBackground
The
/issues/attachmentsand/releases/attachmentsendpoints were placed in theignSignInroute group, which only enforces authentication whenRequireSignInViewis enabled. Since the default is disabled, anonymous users could upload arbitrary files to the server.This could be exploited for:
🤖 Generated with Claude Code