security: prevent deletion of protected and default branches via web UI#8124
Merged
security: prevent deletion of protected and default branches via web UI#8124
Conversation
The DeleteBranchPost function did not check if a branch is protected or is the default branch before allowing deletion. While the UI correctly hides the delete button for protected branches, attackers could bypass this by sending direct POST requests. Added checks to prevent deletion of: - The repository's default branch - Branches with protection enabled Ref: GHSA-2c6v-8r3v-gh6p Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
The
DeleteBranchPostfunction ininternal/route/repo/branch.godid not check if a branch is protected or is the default branch before allowing deletion. While the UI correctly hides the delete button for protected branches (ininternal/route/repo/issue.go:641-654), attackers could bypass this by sending direct POST requests to/branches/delete/<branch>.This vulnerability allows any repository collaborator with Write permissions to:
Changes
Added two checks before allowing branch deletion:
GetProtectBranchOfRepoByNameAlso added the corresponding translation keys for the error messages.
Test plan
References
🤖 Generated with Claude Code