security: fix cross-repository label modification vulnerability#8123
Merged
security: fix cross-repository label modification vulnerability#8123
Conversation
The UpdateLabel function used GetLabelByID which fetches labels without validating repository ownership, allowing authenticated users with write access to any repository to modify labels belonging to other repositories. Changed to use GetLabelOfRepoByID which validates the label belongs to the current repository at the database layer. Ref: GHSA-cv22-72px-f4gh Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateLabelthat allowed cross-repository label tamperingDetails
The
UpdateLabelfunction ininternal/route/repo/issue.gouseddatabase.GetLabelByID(f.ID)which fetches labels without validating repository ownership. This allowed authenticated users with write access to any repository to modify labels belonging to other repositories.Changed to use
database.GetLabelOfRepoByID(c.Repo.Repository.ID, f.ID)which validates the label belongs to the current repository at the database layer, consistent with howDeleteLabeland the API'sEditLabelhandle this.References
🤖 Generated with Claude Code