fix: wiki page delete issue#7656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7596 when PR #103 is merged.
Describe the pull request
It seems there's an issue with the handling of special characters in wiki names, where Git internally escapes them. This creates a mismatch between the escaped filenames and the actual filenames, making it challenging to delete files accurately. As a result, the deletion process is not functioning as expected.
Including the
-zoption in the git ls-tree command results in filenames being presented without quotes.Another pull request has been initiated to handle this specific case. Please check git-module PR #103 for details.
For example, I have created below test wikis:


See the differences of using
-z:Using
-zthe filename is output verbatim.Link to the issue: #7596
Checklist
Test plan
Make sure gogs/git-module has PR #103 changes. And gogs/gogs has this PR changes.
Build(
go build -o gogs) and start the gogs web server(./gogs web).Create wiki pages(with characters like
",\etc,.) and test the fix.Delete.Wiki.Pages.mov