commit: fix matchUsersWithCommitEmails#7561
Merged
Conversation
Set missing value on user variable, each time a new user is returned from db. Fixes gogs#7404
Contributor
Author
|
@unknwon please review and merge 👍 |
matchUsersWithCommitEmails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set missing value on user variable, each time a new user is returned from db.
Fixes #7404
Describe the pull request
This commit fixes the email to user properly handing the returned data from database.
Currently every time we are returning a new user from database, we are caching the value.
But we are not setting value to variable
u, resulting in missing link for user in commit log.Second commit from same user on the list shown as expected.
Link to the issue: #7404
Checklist