dep: update github.com/go-ldap/ldap to v3#6763
Merged
Conversation
Member
|
Thanks for the PR! Looks like the CI is not passing. |
Contributor
Author
|
I've checked and added the updated |
Codecov Report
@@ Coverage Diff @@
## main #6763 +/- ##
========================================
+ Coverage 8.79% 8.80% +0.01%
========================================
Files 97 97
Lines 13208 13208
========================================
+ Hits 1161 1163 +2
+ Misses 11885 11884 -1
+ Partials 162 161 -1 |
Member
|
Did a sanity check and it seems the major difference between this LDAP package v2 and v3 is the enablement of the Go module and should be backwards compatible. |
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Updated LDAP library to v3 in order to fix issues with ARM devices as specified in issue #6761
Link to the issue: #6761
Checklist