Show file name in browser tab title when viewing files#5896
Merged
Show file name in browser tab title when viewing files#5896
Conversation
Member
|
Thanks for the PR! But the CI is failing with some type error. |
roberChen
reviewed
Mar 28, 2020
roberChen
left a comment
There was a problem hiding this comment.
Reason of type error of c.Data["Title"] = blob.Name() + " - " + c.Data["Title"]
internal/route/repo/view.go
Outdated
| return | ||
| } | ||
|
|
||
| c.Data["Title"] = blob.Name() + " - " + c.Data["Title"] |
There was a problem hiding this comment.
see macaron.Context.Data, the type is map[string]interface{}, the c.Data["Title"] should be change to string before adding other string variables.
I've just encountered the problem that when browsing multiple files in different tabs, the tab title does not show the file name, which makes browsing a repository a happy game of memory for the entire family. This PR takes the fun away and should just display the file name in the title.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5896 +/- ##
==========================================
- Coverage 15.28% 0 -15.29%
==========================================
Files 106 0 -106
Lines 13864 0 -13864
==========================================
- Hits 2119 0 -2119
+ Misses 11465 0 -11465
+ Partials 280 0 -280 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've just encountered the problem that when browsing multiple files in different tabs, the tab title does not show the file name, which makes browsing a repository a happy game of memory for the entire family. This PR takes the fun away and should just display the file name in the title.