feat: add directory support#49
Closed
tharvik wants to merge 3 commits intogofrs:masterfrom
tharvik:add-directory-support
Closed
feat: add directory support#49tharvik wants to merge 3 commits intogofrs:masterfrom tharvik:add-directory-support
tharvik wants to merge 3 commits intogofrs:masterfrom
tharvik:add-directory-support
Conversation
Member
|
@tharvik working on seeing if I can get access to an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup of #39.
Comment from @theckman
So, I splitted setFh in the system specific files, that should do the trick. I'm unable to test for AIX but windows & linux pass the tests. I've keep the doubling of the main test suite, one with a file, another with a directory.
NB: on master, two examples in
flock_example_test.go(namelyExampleFlock_TryLock&ExampleFlock_TryLockContext) are not being run, because of missing// Output:line.