Merged
Conversation
9fa3b6d to
958d664
Compare
Contributor
Author
|
Howdy @theckman sorry to ping you, do you have the time to review ? Should I ping someone else ? |
theckman
requested changes
Aug 31, 2019
Member
theckman
left a comment
There was a problem hiding this comment.
Thank you for this contribution, it looks great! 👍 I do have two small suggestions that I'd love your thoughts on, but beyond those this looks good to go.
Contributor
Author
|
Hello there ! So sorry the notification for this completely went past my attention ! I applied your suggestions there 🙂 I agree it's better to say what went wrong |
Contributor
Author
|
Hello there sorry to bump you, is there something else I can do to make this PR better ? Thanks ! |
theckman
approved these changes
Aug 22, 2020
Contributor
Author
|
Thanks ! |
Member
|
Thank you for the contribution!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Howdy, this supersedes and closes #31, fixes #30
based on comments of #31.
The only way to test private fields was to create a new testing file.