Skip to content

fix: handle x-ratelimit-reset for secondary rate limit#10

Merged
gofri merged 7 commits intomainfrom
gofri/handle-x-ratelimit
Apr 29, 2023
Merged

fix: handle x-ratelimit-reset for secondary rate limit#10
gofri merged 7 commits intomainfrom
gofri/handle-x-ratelimit

Conversation

@gofri
Copy link
Copy Markdown
Owner

@gofri gofri commented Apr 29, 2023

fixes #9
while at it, this PR also:

  • fixes typos in documentation
  • exports header keys as consts
  • makes Base (the base roundtripper) public
  • moves the testing into the github_ratelimit_test package -- making them clear close-box testing

@gofri gofri merged commit 70bfde2 into main Apr 29, 2023
@gofri gofri deleted the gofri/handle-x-ratelimit branch December 23, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Callback function doesn't trigger after secondary rate limit is hit

1 participant