Merged
Conversation
Avoid unnecessary pointer dereferencing #Before ``` Benchmark_ToString-24 3499046 339.2 ns/op 96 B/op 6 allocs/op Benchmark_ToString-24 3552510 336.8 ns/op 96 B/op 6 allocs/op Benchmark_ToString-24 3589656 335.2 ns/op 96 B/op 6 allocs/op Benchmark_ToString-24 3564043 337.8 ns/op 96 B/op 6 allocs/op ``` #After ``` Benchmark_ToString-24 4211290 285.7 ns/op 96 B/op 6 allocs/op Benchmark_ToString-24 4296464 282.5 ns/op 96 B/op 6 allocs/op Benchmark_ToString-24 4279908 283.5 ns/op 96 B/op 6 allocs/op Benchmark_ToString-24 4216419 283.5 ns/op 96 B/op 6 allocs/op ```
efectn
reviewed
Feb 8, 2024
Member
|
The previous benchmark had 10x more performance. https://github.com/gofiber/utils/actions/runs/7753577848/job/21145172120 Is this related to the change in the benchmark code? |
Member
Author
Yes, see #62 (comment) |
efectn
reviewed
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convert.go#ToString