🔥 Add IsIPv4/v6 util#32
Merged
jozsefsallai merged 2 commits intogofiber:masterfrom Oct 17, 2022
sadfun:master
Merged
Conversation
jozsefsallai
suggested changes
Oct 17, 2022
Member
jozsefsallai
left a comment
There was a problem hiding this comment.
Just a small nitpick regarding the phrasing of the comment. If you can change this according to the suggestion and the workflow runs will succeed, I can merge this
ips.go
Outdated
Comment on lines
+5
to
+6
| // IsIPv4 is plagiarism of net.ParseIP, | ||
| // but without check for IPv6 case and without returning net.IP slice, whereby IsIPv4 makes no allocations. |
Member
There was a problem hiding this comment.
"plagiarism" feels like too strong of a word, maybe reword the comment to say
// IsIPv4 is a copy of the standard net.ParseIP function but without special checks
// for IPv6 and without returning a net.IP slice, thus resulting in no allocations.same for IsIPv6
ips.go
Outdated
Comment on lines
+43
to
+44
| // IsIPv6 is plagiarism of net.ParseIP, | ||
| // but without check for IPv4 case and without returning net.IP slice, whereby IsIPv6 makes no allocations. |
Member
|
Also the linter warning |
jozsefsallai
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding utils (and tests) for IP addresses validation. Used in #2168.