• common.go
  • Added defaultSecureTokenLength and maxFastTokenEncodedLength constants.
  • Implemented a fast path in GenerateSecureToken for 32-byte tokens to reduce heap allocations.
  • Updated SecureToken to use the new defaultSecureTokenLength constant.
  • Introduced a fast path in ConvertToBytes for simple numeric and byte-suffixed strings.
• format.go
  • Declared uint8Strs and int8Strs arrays for precomputing string representations of uint8 and int8 values.
  • Populated uint8Strs and int8Strs in the init() function.
  • Added formatUint8Slow helper function.
  • Refactored FormatUint8 and FormatInt8 to use the precomputed string arrays.
• http.go
  • Defined constants for common application/ content types and their prefix length.
  • Added a fast path in ParseVendorSpecificContentType to return precomputed strings for common types.
• parse.go
  • Introduced fracScale array for precomputed fractional values.
  • Implemented fast paths in ParseInt8 and ParseUint8 for short numeric strings (up to 3 digits).
  • Optimized parseSigned and parseUnsigned with a fast path for strings up to 19 digits, avoiding parseDigits for these cases.
  • Modified parseFloat to use the fracScale array for fractional part calculation.
• strings.go
  • Optimized ToLower and ToUpper functions by processing multiple characters at a time (4-byte chunks) after the first case change, improving conversion speed.

• No specific activity (comments, reviews, etc.) was provided for this pull request.

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   84.77%   84.52%   -0.26%     
==========================================
  Files          12       12              
  Lines         939     1053     +114     
==========================================
+ Hits          796      890      +94     
- Misses        124      136      +12     
- Partials       19       27       +8     

Flags with carried forward coverage won't be shown. Click here to find out more.

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

common.go (1)

77-86: Nit: encodedLen is always maxFastTokenEncodedLength on this branch.

Since this branch is guarded by length == defaultSecureTokenLength, base64.RawURLEncoding.EncodedLen(length) is always 43. You already have the maxFastTokenEncodedLength constant for this — using it directly would remove the redundant call and make the relationship explicit.

♻️ Suggested simplification

 	if length == defaultSecureTokenLength {
 		var randomBuf [defaultSecureTokenLength]byte
 		src := randomBuf[:]
 		readRandomOrPanic(src)
 
 		var encoded [maxFastTokenEncodedLength]byte
-		encodedLen := base64.RawURLEncoding.EncodedLen(length)
-		base64.RawURLEncoding.Encode(encoded[:encodedLen], src)
-		return string(encoded[:encodedLen])
+		base64.RawURLEncoding.Encode(encoded[:maxFastTokenEncodedLength], src)
+		return string(encoded[:maxFastTokenEncodedLength])
 	}

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

• X
• Mastodon
• Reddit
• LinkedIn