chore: modernize loop in IsIPv4

arturmelanchyk · arturmelanchyk · commit eb8645be0089 · 2025-11-03T17:59:47.000+01:00
Signed-off-by: Artur Melanchyk &lt;13834276+arturmelanchyk@users.noreply.github.com&gt;
diff --git a/ips.go b/ips.go
@@ -8,7 +8,7 @@ import (
 // but without check for IPv6 case and without returning net.IP slice, whereby IsIPv4 makes no allocations.
 func IsIPv4(s string) bool {
 	//nolint:modernize-loop // old way is more readable
-	for i := 0; i < net.IPv4len; i++ {
+	for i := range net.IPv4len {
 		if len(s) == 0 {
 			return false
 		}
diff --git a/ips_test.go b/ips_test.go
@@ -101,7 +101,7 @@ func Test_IPWhitespace(t *testing.T) {
 	require.False(t, IsIPv6("::1 "))
 }
 
-// go test -v -run=^$ -bench=UnsafeString -benchmem -count=2
+// go test -v -run=^$ -bench=Benchmark_IsIPv4 -benchmem -count=6
 func Benchmark_IsIPv4(b *testing.B) {
 	ip := "174.23.33.100"
 	var res bool
@@ -121,7 +121,7 @@ func Benchmark_IsIPv4(b *testing.B) {
 	})
 }
 
-// go test -v -run=^$ -bench=UnsafeString -benchmem -count=2
+// go test -v -run=^$ -bench=Benchmark_IsIPv6 -benchmem -count=6
 func Benchmark_IsIPv6(b *testing.B) {
 	ip := "9396:9549:b4f7:8ed0:4791:1330:8c06:e62d"
 	var res bool

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ import (`
`8`	`8`	`// but without check for IPv6 case and without returning net.IP slice, whereby IsIPv4 makes no allocations.`
`9`	`9`	`func IsIPv4(s string) bool {`
`10`	`10`	`//nolint:modernize-loop // old way is more readable`
`11`		`- for i := 0; i < net.IPv4len; i++ {`
	`11`	`+ for i := range net.IPv4len {`
`12`	`12`	`if len(s) == 0 {`
`13`	`13`	`return false`
`14`	`14`	`}`