Skip to content

replace register method to Add in App.Use #590

Closed
songjiayang wants to merge 1 commit intogofiber:masterfrom
songjiayang:refactor_app_use
Closed

replace register method to Add in App.Use #590
songjiayang wants to merge 1 commit intogofiber:masterfrom
songjiayang:refactor_app_use

Conversation

@songjiayang
Copy link
Contributor

changing for the same behavior with app.Get.

@songjiayang songjiayang requested a review from a team as a code owner July 12, 2020 09:37
@songjiayang songjiayang requested review from jozsefsallai and koddr and removed request for a team July 12, 2020 09:37
@kiyonlin
Copy link
Contributor

Thanks for the PR.

But I think in the package, use register is better. The Add is for users outside the package.

@Fenny
Copy link
Member

Fenny commented Jul 12, 2020

Thanks for the PR @songjiayang, @kiyonlin is right regarding the use of the app.Add method.
Its purpose is to register HTTP methods, where USE is a custom verb in the Fiber framework.

We appreciate your contribution by providing optimizations/alternatives ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants