ci: remove duplicate benchmark handling and update benchmark action version#4108
ci: remove duplicate benchmark handling and update benchmark action version#4108ReneWerner87 merged 4 commits intomainfrom
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4108 +/- ##
==========================================
- Coverage 91.04% 91.03% -0.02%
==========================================
Files 119 119
Lines 11385 11385
==========================================
- Hits 10366 10364 -2
- Misses 647 648 +1
- Partials 372 373 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes a manual workaround for handling duplicate benchmark names in Go benchmarks and updates the benchmark action to use a version that includes native support for this functionality via the go-force-package-suffix option. The change simplifies the workflow by eliminating ~30 lines of complex awk-based preprocessing.
Changes:
- Removed manual awk-based duplicate benchmark name handling workaround (4 steps, ~30 lines)
- Updated benchmark-action/github-action-benchmark from v1.20.7 to commit from PR #337
- Added
go-force-package-suffix: trueparameter to all three benchmark action invocations
|
upstream PR was merged |
related to the benchmark-action/github-action-benchmark#337