• client/core.go
  • Added a new exported error, ErrResponseClientNil, for cases where a response client is nil.
• client/response.go
  • Added nil checks to JSON, CBOR, and XML methods to return ErrResponseClientNil if the client is not set.
• client/response_test.go
  • Added Test_Response_DecodeHelpers_ClientNilSafety to validate nil-safety and correct error handling for decode helpers.

• Ran go test ./client -run Test_Response_DecodeHelpers_ClientNilSafety -count=1 which passed.
• Executed the full test suite via make test, which passed.
• Performed make generate, make betteralign, make modernize, make format, and make lint, all succeeding.
• Ran make audit, which failed due to environment-specific govulncheck issues unrelated to the PR changes.

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

client/response_test.go (1)

475-478: Nit: require inside NotPanics can mask the real failure message.

require.ErrorIs calls t.FailNow() → runtime.Goexit() on failure. While recover() won't intercept it (so NotPanics won't false-positive report a panic), the test output can be confusing because NotPanics still runs its own assertion after Goexit unwinds deferred functions. A clearer pattern is to capture the error and assert outside:

♻️ Suggested refactor (example for the JSON subtest)

-			require.NotPanics(t, func() {
-				err := resp.JSON(&decoded)
-				require.ErrorIs(t, err, ErrClientNil)
-			})
+			var err error
+			require.NotPanics(t, func() {
+				err = resp.JSON(&decoded)
+			})
+			require.ErrorIs(t, err, ErrClientNil)

Same pattern applies to the XML and CBOR nil-client subtests.

Also applies to: 491-494, 507-510

• X
• Mastodon
• Reddit
• LinkedIn

@@            Coverage Diff             @@
##             main    #4081      +/-   ##
==========================================
+ Coverage   90.99%   91.04%   +0.05%     
==========================================
  Files         119      119              
  Lines       11256    11277      +21     
==========================================
+ Hits        10242    10267      +25     
+ Misses        642      638       -4     
  Partials      372      372              

Flags with carried forward coverage won't be shown. Click here to find out more.

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.